wip: added charm config #117
Conversation
Demo
Jenkins 
demos.haus 
.env
Outdated
| @@ -17,3 +17,4 @@ GOOGLE_DRIVE_FOLDER_ID=googlecreds | |||
| COPYDOC_TEMPLATE_ID=googlecreds | |||
| GOOGLE_PRIVATE_KEY=base64encodedprivatekey | |||
| GOOGLE_PRIVATE_KEY_ID=privatekeyid | |||
| FLASK_DEBUG=1 | |||
There was a problem hiding this comment.
I think this is better be set in .env.local?
| @@ -0,0 +1,9 @@ | |||
| venv/ | |||
There was a problem hiding this comment.
It's created by default by the charm initialization, along with some charm src files, so I've left it as is
webapp/__init__.py
Outdated
| @@ -38,7 +49,7 @@ def create_app(): | |||
| init_cache(app) | |||
|
|
|||
| # Initialize tasks | |||
| init_tasks(app) | |||
| # init_tasks(app) | |||
There was a problem hiding this comment.
if this is not needed, can it be removed? Also, could you please explain how the tasks are going to be launched now?
There was a problem hiding this comment.
Yes, I'll remove it.
We're now using celery which will coordinate the background tasks between instances. I'm adding a section to the README
|
|
||
| self.logger.info(f"Loading {self.repository_uri} from database") | ||
| self.invalidate_cache() |
There was a problem hiding this comment.
can you explain this change please?
There was a problem hiding this comment.
Its just a stylistic change because the else: branch was redundant and I prefer putting the log first before any other process starts
| # Create the locks for the site trees | ||
| LOCKS = {} | ||
| # Default delay between runs for scheduled tasks | ||
| TASK_DELAY = int(os.getenv("TASK_DELAY", 5)) |
There was a problem hiding this comment.
please rebase against main, as I added another task that has a different periodicity.
There was a problem hiding this comment.
Ah, okay. Lemme do that and include the changes as we're now using celery for the periodic tasks.
I'll also update the readme
Done
QA
QA steps
Fixes
Screenshots
It could be helpful to provide some screenshots to aid in QAing the change.